Make Bolt adaptor work with JRuby #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby does not support BasicSocket#sendmsg, but it does support BasicSocket#send.
1 similar comment
|
Excellent, thank you! |
cheerfulstoic
pushed a commit
that referenced
this pull request
Aug 22, 2017
JRuby does not support BasicSocket#sendmsg, but it does support BasicSocket#send. (cherry picked from commit a993795)
cheerfulstoic
added a commit
that referenced
this pull request
Aug 22, 2017
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby does not support
BasicSocket#sendmsg(connecting via Bolt on JRuby crashed with aNotImplementedError), but it does supportBasicSocket#send.sendrequires flags to be specified, butsendmsgdefaults them to0, so I just used that since we weren't overriding that default here anyway.This all started as an experiment to see if JRuby would run Bolt faster than HTTP, but that's not the case, unfortunately. JRuby Bolt is indeed over 2.5x as fast as CRuby Bolt, but still lags behind JRuby HTTP and CRuby HTTP (which are actually pretty close to each other) by about 37%.
Tested with JRuby 9.1.12.0 on Java 8 on queries deserializing 18k nodes.
Pings:
@cheerfulstoic
@subvertallchris