Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt+routing #335

Closed
wants to merge 2 commits into from
Closed

Bolt+routing #335

wants to merge 2 commits into from

Conversation

ekampp
Copy link

@ekampp ekampp commented Dec 26, 2019

Based on this, previous dicussion, this attempts to reimplement bolt+routing for causal cluster load balancing.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 86.814% when pulling e1be7fa on systems-engineering:master into 4b649fc on neo4jrb:master.

@klobuczek
Copy link
Member

@ekampp this PR implements only the load balancing aspect of causal clustering. Full clustering cannot be implemented with an adapter and without changes to the current neo4jrb DSL and the client code. What is missing is handling bookmarks to ensure reading your own writes. With the current adapter approach, 1 transaction per query, this is not achievable. We intend to provide explicit session and transaction demarcation in neo4j-10.0.x the same way as in neo4j-ruby-driver. The bookmarks obtained from a session must be provided to the next session if a guarantee is needed that all transactions are routed to servers caught up with all transactions of the previous session.

@ekampp
Copy link
Author

ekampp commented Jan 6, 2020

@klobuczek, thanks for the feedback!

I have also added this PR to neo4j it self for the session management.

When is 10.0.x expected to be launched, and how will that help this situation? I'm not sure I understand the jargon around transaction demarcation. Sorry.

Thanks,
Emil

@ekampp ekampp closed this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants