feat: use diagnostic level to control levels #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng JIANG <alex_cj96@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng JIANG alex_cj96@foxmail.com
I'd really like to re-open this in case someone needs it like me. I still think coc-eslint doesn't need to do exactly like vscode-eslint. Users just need to have more possibilities.
I need quiet mode because some projects don't have eslint configuration or contains bad eslint configuration. I'd be crazy if an error being thrown out everytime when I open a file...
However, quiet mode filters eslint warnings like vscode-eslint, but I really need it because it gives me more information and I can control diagnostic levels globally.