Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13 from neocotic/wip-1.0.0
1.0.0 WIP
- Loading branch information
Showing
19 changed files
with
1,051 additions
and
555 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
node_modules/ | ||
node_modules | ||
npm-debug.log | ||
|
||
.DS_Store? | ||
ehthumbs.db | ||
Icon? | ||
Thumbs.db | ||
Thumbs.db |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
docs | ||
test | ||
.jshintrc | ||
.travis.yml | ||
AUTHORS.md | ||
CHANGES.md | ||
CONTRIBUTING.md | ||
Gruntfile.js | ||
README.md | ||
backbone.do.min.js | ||
backbone.do.min.map | ||
bower.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ language: node_js | |
node_js: | ||
- "0.10" | ||
before_script: | ||
- npm install -g grunt-cli | ||
- npm install -g grunt-cli |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
# Authors ordered by first contribution | ||
|
||
* Alasdair Mercer <mercer.alasdair@gmail.com> | ||
* Alasdair Mercer <mercer.alasdair@gmail.com> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,38 @@ | ||
# Contributing | ||
|
||
Here are some guidelines that we'd like contributors to follow so that we can | ||
have a chance of keeping things right. | ||
|
||
## Getting Starting | ||
|
||
* Make sure you have a [GitHub account](https://github.com/signup/free) | ||
* Submit a ticket for your issue if one does not already exist | ||
* Clearly describe the issue including steps to reproduce when it is a bug | ||
* Include the earliest version that you know has the issue | ||
* Fork the repository on GitHub | ||
|
||
## Making Changes | ||
|
||
* Create a topic branch from where you want to base your work | ||
* This is usually the master branch | ||
* Only target release branches if you are certain your fix must be on that | ||
branch | ||
* To quickly create a topic branch based on master; `git branch | ||
fix/master/my_contribution master` then checkout the new branch with `git | ||
checkout fix/master/my_contribution` | ||
* Avoid working directly on the `master` branch | ||
* Make commits of logical units | ||
* Check for unnecessary whitespace with `git diff --check` before committing | ||
* Make sure your commit messages are in the proper format | ||
``` | ||
(#99999) Make the example in CONTRIBUTING imperative and concrete | ||
If you have any questions about [Backbone.Do][0] please feel free to [raise an issue][2]. | ||
|
||
Please [search existing issues][1] for the same feature and/or issue before raising a new issue. Commenting on an | ||
existing issue is usually preferred over raising duplicate issues. | ||
|
||
Without this patch applied the example commit message in the CONTRIBUTING | ||
document is not a concrete example. This is a problem because the | ||
contributor is left to imagine what the commit message should look like | ||
based on a description rather than an example. This patch fixes the | ||
problem by making the example concrete and imperative. | ||
Ensure that you update any relevant unit tests (in the `test` directory) and that all tests are currently passing. This | ||
can be done easily via command-line: | ||
|
||
The first line is a real life imperative statement with a ticket number | ||
from our issue tracker. The body describes the behavior without the patch, | ||
why this is a problem, and how the patch fixes the problem when applied. | ||
``` bash | ||
# install/update package dependencies | ||
$ npm install | ||
# run test suite | ||
$ grunt test | ||
``` | ||
* Make sure you have added the necessary tests for your changes | ||
* Run *all* the tests to assure nothing else was accidentally broken | ||
|
||
## Submitting Changes | ||
You will obviously need to have [node.js][3] for this, but you should also need to install (if you haven't done so | ||
already) the [Grunt][4] command-line tool: | ||
|
||
* Ensure you added your details to `AUTHORS.md` in the correct format | ||
``` bash | ||
$ npm install -g grunt-cli | ||
``` | ||
* Joe Bloggs <joe.bloggs@example.com> | ||
``` | ||
* Push your changes to a topic branch in your fork of the repository | ||
* Submit a pull request to neocotic's repository | ||
* Update your issue to mark that you have submitted code and are ready for it | ||
to be reviewed | ||
* Include a link to the pull request in the issue | ||
|
||
# Additional Resources | ||
|
||
* [Backbone.Do repository](https://github.com/neocotic/Backbone.Do) | ||
* [Issue tracker](https://github.com/neocotic/Backbone.Do/issues) | ||
* [General GitHub documentation](http://help.github.com) | ||
* [GitHub pull request documentation](http://help.github.com/send-pull-requests) | ||
|
||
Use the same coding style as the rest of the [code base][0]. | ||
|
||
When submitting a pull request, please do *not* build the documentation or the minified files. We will built the | ||
distributables when cutting a release. | ||
|
||
All pull requests should be made to the `develop` branch. | ||
|
||
Don't forget to add your details to the list of `AUTHORS.md` if you want your contribution to be recognized by others. | ||
|
||
[0]: https://github.com/neocotic/Backbone.Do | ||
[1]: https://github.com/neocotic/Backbone.Do/issues | ||
[2]: https://github.com/neocotic/Backbone.Do/issues/new | ||
[3]: http://nodejs.org | ||
[4]: http://gruntjs.com |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.