Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error being thrown caused by lost context for CLI #24

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Error being thrown caused by lost context for CLI #24

merged 1 commit into from
Nov 21, 2017

Conversation

leblanc-simon
Copy link
Contributor

With the new version converter require a provider. In CLI, this provider is not set in the constructor.

This fix set the provider when you use the CLI

@neocotic neocotic changed the base branch from master to develop November 21, 2017 08:57
@neocotic neocotic self-requested a review November 21, 2017 08:57
@neocotic neocotic added the bug label Nov 21, 2017
Copy link
Owner

@neocotic neocotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Annoyed that I missed this. A sign that I really need to work on #21 to cover the CLI.

@neocotic neocotic added this to the 0.3.2 milestone Nov 21, 2017
@neocotic
Copy link
Owner

Thanks for your contribution! I'll merge this and hope to get it released soon.

@neocotic neocotic merged commit 30d6cee into neocotic:develop Nov 21, 2017
@neocotic neocotic changed the title fix(convert-svg-core): fixed error being throw caused by lost context for CLI Error being thrown caused by lost context for CLI Nov 21, 2017
@neocotic neocotic mentioned this pull request Nov 21, 2017
3 tasks
@neocotic
Copy link
Owner

Thanks again for your contribution @leblanc-simon. I've just released v0.3.2 which includes this fix. Install it and let me know how you get on 😄

@leblanc-simon leblanc-simon deleted the fix/provider-not-found branch December 7, 2017 01:09
@leblanc-simon
Copy link
Contributor Author

@neocotic it's perfect ! Thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants