Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests against malformed HTML in scaffolding.html #27

Closed
tjchaplin opened this issue Aug 14, 2013 · 1 comment
Closed

Failing tests against malformed HTML in scaffolding.html #27

tjchaplin opened this issue Aug 14, 2013 · 1 comment
Assignees
@neocotic
Milestone
3.0.0

Comments

@tjchaplin
Copy link
Contributor

When html is malformed the tests are failing. When html is like:

<html>
    ....
    <command>Some contents</command>
</html>

The generated markdown will contain Some contents. The tests don't expect Some contents and are therefore failing.
@neocotic
Copy link
Owner

By malformed, do you just mean unknown tags? I'm not seeing any failed tests.

tjchaplin added a commit to tjchaplin/html.md that referenced this issue Aug 14, 2013
@tjchaplin
(neocotic#27) Updates test fixture to contain properly formatted html
03682c4 
This patch is needed so that tests pass properly and work with valid html. The malformed html was specific to **void elements**.  **void elements** shouldn't contain any contents.  See W3 standard for further reference[1](http://www.w3.org/TR/html-markup/syntax.html#void-element).

The patch has updated the test fixture so that it doesn't contain the malformed html.
@tjchaplin tjchaplin mentioned this issue Aug 14, 2013
Closed
@neocotic neocotic mentioned this issue Aug 15, 2013
Merged
@ghost ghost assigned neocotic Aug 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocotic neocotic

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

(#27) Updates test fixture to contain properly formatted html tjchaplin/html.md
2 participants
@neocotic @tjchaplin