Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js < 4 #74

Closed
neocotic opened this issue May 29, 2017 · 2 comments
Closed

Drop support for Node.js < 4 #74

neocotic opened this issue May 29, 2017 · 2 comments

Comments

@neocotic
Copy link
Owner

The current build contains unnecessary complexity as it tries to support Node.js 0.10 and 0.12 to some degree. I'd like to drop that support and simplify our build and contributor guidelines in the progress.

@neocotic
Copy link
Owner Author

To clarify; I do not intend on adding code the source code that would not run on 0.10 or 0.12 and, since we don't currently have unit tests, there is no safe guards that it ever does anyway. However, I'd like to remove support for these versions from the build so that it's much simpler and so that we can require npm@5 in order to take advantage of lock files etc.

@neocotic
Copy link
Owner Author

I will also be adding support for the newly released Node.js 8. This will only include running the CI build on node@8 for now.

This will obviously have more meaning if/when we get around to creating unit tests.

neocotic added a commit that referenced this issue May 31, 2017
@neocotic neocotic mentioned this issue May 31, 2017
4 tasks
@neocotic neocotic self-assigned this May 31, 2017
@neocotic neocotic closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant