(#2) Make the QR-code center-aligned #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
The only problem that I have with this PR is that it makes too many unrelated changes to formatting. If these could be reverted so that only the necessary changes are included, I'll happily merge this in. |
|
@neocotic done :) |
|
Great! I'll take a look at this tomorrow night. Sorry for the delay with this. |
|
@mjmasn I've merged your fix and it's been included in v1.1.4 which I've just published. Thanks for all your help! |
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch applied the QR-code will be aligned to the top-left of the output image/canvas. If the QR-code is smaller than the image size, there will be whitespace to the bottom-right of the image. This patch fixes this by calculating an offset to make the whitespace equal on all sides of the QR-code.
Fixes #2