Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastd 22 build issue #19

Closed
chenrui333 opened this issue Jun 29, 2021 · 3 comments · Fixed by #20
Closed

fastd 22 build issue #19

chenrui333 opened this issue Jun 29, 2021 · 3 comments · Fixed by #20

Comments

@chenrui333
Copy link

clang -Isrc/liblibfastd.a.p -Isrc -I../src -I/opt/homebrew/Cellar/libuecc/7/include/libuecc-7 -I/opt/homebrew/Cellar/json-c/0.15/include -I/opt/homebrew/Cellar/json-c/0.15/include/json-c -I/opt/homebrew/Cellar/openssl@1.1/1.1.1k/include -I/opt/homebrew/Cellar/libsodium/1.0.18_1/include -fcolor-diagnostics -Wall -Winvalid-pch -Wextra -std=c99 -O3 -D_GNU_SOURCE -D__APPLE_USE_RFC_3542 -MD -MQ src/liblibfastd.a.p/handshake.c.o -MF src/liblibfastd.a.p/handshake.c.o.d -o src/liblibfastd.a.p/handshake.c.o -c ../src/handshake.c
../src/handshake.c:293:14: error: implicit declaration of function 'htobe16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
.length = htobe16(sizeof(header)),
^
1 error generated.

relates to

full build log:
https://github.com/Homebrew/homebrew-core/runs/2939005147

neocturne added a commit that referenced this issue Jun 29, 2021
At the moment, only htobe16() is used, breaking build on OSX.

Fixes #19
@neocturne
Copy link
Owner

Sorry about that, I currently don't have a MacOS host for build tests. Please test the fix in #20.

@chenrui333
Copy link
Author

no worries apply your patch commit in this PR

@chenrui333
Copy link
Author

@NeoRaider the fix works for me (just tested out on my Mojave machine), thanks!

neocturne added a commit that referenced this issue Jun 30, 2021
At the moment, only htobe16() is used, breaking build on OSX.

Fixes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants