Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create example that uses CompactString #14

Closed
neoeinstein opened this issue Jun 19, 2022 · 0 comments · Fixed by #15
Closed

Create example that uses CompactString #14

neoeinstein opened this issue Jun 19, 2022 · 0 comments · Fixed by #15

Comments

@neoeinstein
Copy link
Owner

Relies on ParkMyCar/compact_str#117, with a pending PR: ParkMyCar/compact_str#118.

The example is already prepared, but needs to be uncommented and re-published when compact_str is released with the necessary trait.
neoeinstein added a commit that referenced this issue Jun 20, 2022
@neoeinstein
feat: add no_expose parameter, CompactString example
0760fc4 
Closes #14
@neoeinstein neoeinstein mentioned this issue Jun 20, 2022
Merged
neoeinstein added a commit that referenced this issue Jun 20, 2022
@neoeinstein
feat: add no_expose parameter, CompactString example
4a854e0 
Closes #14
neoeinstein added a commit that referenced this issue Jun 20, 2022
@neoeinstein
feat: add no_expose parameter, CompactString example
2c96335 
Closes #14
neoeinstein added a commit that referenced this issue Jun 22, 2022
@neoeinstein
feat: add no_expose parameter, CompactString example
e49beb7 
Closes #14
bors bot added a commit that referenced this issue Jun 22, 2022
@bors @neoeinstein
Merge #15
f0c14ea 
15: feat: add no_expose parameter r=neoeinstein a=neoeinstein

In order to avoid exposing the inner type, we need to add a requirement on the `Validator::Error` type to ensure that we can at least convert from `Infallible`. To support this trivial implementation, I've added a `from_infallible!()` macro that provides that impl.

Closes #14

Co-authored-by: Marcus Griep <marcus@griep.us>
@bors bors bot closed this as completed in a58098e Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add no_expose parameter neoeinstein/aliri_braid
1 participant
@neoeinstein