Get rid of the jopt dep and pin typetools

neoforged · Oct 30, 2023 · 98a62a3 · 98a62a3
1 parent be49550
commit 98a62a3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/build-prs.yml b/.github/workflows/build-prs.yml
@@ -14,6 +14,9 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 1000
+          fetch-tags: true
 
       - name: Setup JDK 17
         uses: actions/setup-java@v2

diff --git a/build.gradle b/build.gradle
@@ -30,10 +30,7 @@ allprojects {
             url = 'https://maven.neoforged.net/'
         }
     }
-
-    dependencies.testRuntimeOnly('org.apiguardian:apiguardian-api:1.1.2') // No idea why, but windows needs this to not explode.
-    dependencies.implementation('net.sf.jopt-simple:jopt-simple:5.0.4') // Modlauncher depends on this but doesnt do it transitivly so the tests need it explit
-
+
     extraJavaModuleInfo {
         failOnMissingModuleInfo = false
         automaticModule('jmh-core-1.35.jar', 'jmh.core')
@@ -100,7 +97,7 @@ dependencies {
     implementation('org.ow2.asm:asm:9.2')
     implementation('org.apache.logging.log4j:log4j-api:2.17.1')
     compileOnly('org.jetbrains:annotations:23.0.0')
-    api('net.jodah:typetools:0.6.+')
+    api('net.jodah:typetools:0.6.3')
 }
 
 nexusPublishing {

diff --git a/bus-test/src/test/java/module-info.java b/bus-test/src/test/java/module-info.java
@@ -3,7 +3,6 @@
     requires org.apache.logging.log4j;
     requires org.apache.logging.log4j.core;
     requires net.neoforged.bus;
-    requires jopt.simple;
 
     requires static org.jetbrains.annotations;