Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STARTUP configs for early config loading/usage #150

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

@TelepathicGrunt TelepathicGrunt commented May 27, 2024

I think this is all that is needed. JUnit tests ran so I didn't completely kill the build lol

See neoforged/NeoForge#723

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 27, 2024

  • Publish PR to GitHub Packages

Last commit published: 7f046cc0edcbbfb98738886845a4e54ca0fffd6a.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #150' // https://github.com/neoforged/FancyModLoader/pull/150
        url 'https://prmaven.neoforged.net/FancyModLoader/pr150'
        content {
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
        }
    }
}

@Technici4n
Copy link
Member

I'm happy to test this once there is a corresponding NF PR. 😉

@TelepathicGrunt
Copy link
Contributor Author

@Technici4n what needs to happen on the Neo PR? Just a test mod there to test it? How would I have the Neo pr build against this fml pr?

@Technici4n
Copy link
Member

You can use PR publishing for that. 😉

Check #150 (comment) once it's finished publishing.

TelepathicGrunt added a commit to TelepathicGrunt/NeoForge that referenced this pull request May 29, 2024
Technici4n
Technici4n previously approved these changes Jun 2, 2024
TelepathicGrunt and others added 2 commits June 2, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants