Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some configuration cache violations #19

Merged
merged 4 commits into from Mar 19, 2024
Merged

Conversation

lukebemish
Copy link
Contributor

This PR fixes two configuration cache violations:

  • The shouldSign convention no longer has serialization issues
  • The maven publication reporting service is now fed proper publication data even when the transient task.publication fields are not present when restoring from cache, by capturing the relevant values from them in providers.

Testing locally, this is enough to allow building and locally publishing NeoGradle with configuration caching enabled.

@lukebemish
Copy link
Contributor Author

lukebemish commented Mar 19, 2024

No clue how version bumps work for this project so leaving that out. I'll also note that maty seems to have done - entirely independently - the same fix as I did to the first violation on the fix/configcache branch, though this also fixes the second issue which is a bit... weirder, thanks to gradle's weirdness with config cache and publications.

@Matyrobbrt Matyrobbrt added the bug Something isn't working label Mar 19, 2024
@Matyrobbrt Matyrobbrt merged commit 287df22 into neoforged:main Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants