[21.1+] Generalise lightable blocks #1186
Conversation
|
Matyrobbrt
added
enhancement
| serverlevel.setBlockAndUpdate(blockpos, BaseFireBlock.getState(serverlevel, blockpos)); | ||
| serverlevel.gameEvent(null, GameEvent.BLOCK_PLACE, blockpos); | ||
| - } else if (CampfireBlock.canLight(blockstate) || CandleBlock.canLight(blockstate) || CandleCakeBlock.canLight(blockstate)) { | ||
| + } else if (blockstate.getBlock() instanceof net.neoforged.neoforge.common.SpecialLightableBlock && ((net.neoforged.neoforge.common.SpecialLightableBlock) blockstate.getBlock()).canLight(blockstate)) { | ||
| serverlevel.setBlockAndUpdate(blockpos, blockstate.setValue(BlockStateProperties.LIT, Boolean.valueOf(true))); |
There was a problem hiding this comment.
Still sets the LIT property here
| BlockState blockstate = level.getBlockState(blockpos); | ||
| boolean flag = false; | ||
| - if (!CampfireBlock.canLight(blockstate) && !CandleBlock.canLight(blockstate) && !CandleCakeBlock.canLight(blockstate)) { | ||
| + if (blockstate.getBlock() instanceof net.neoforged.neoforge.common.SpecialLightableBlock && !((net.neoforged.neoforge.common.SpecialLightableBlock) blockstate.getBlock()).canLight(blockstate)) { |
There was a problem hiding this comment.
wrong logic, instead of catching unlightable blocks and lightable blocks that refuse, it only catches the latter. Should be !(instanceof) || !canLight()
I don't see the else, but I suspect it also sets LIT
It may be a machine or a multiblock formation trigger or something that triggers an action but doesn't actually need a blockstate for that. |
|
After looking around a bit, this seems more like a candidate for ItemAbilities. Sorry, I hadn't seen those before. |
What the title says
Fixed #1179