-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to NBTIngredient for handling attachments #638
Add support to NBTIngredient for handling attachments #638
Conversation
Last commit published: e8a4ba76aa8868625667a4e0c22256ccfc0fcada. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #638' // https://github.com/neoforged/NeoForge/pull/638
url 'https://prmaven.neoforged.net/NeoForge/pr638'
content {
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr638
cd NeoForge-pr638
curl -L https://prmaven.neoforged.net/NeoForge/pr638/net/neoforged/neoforge/20.4.177-pr-638-attachment_ingredients/mdk-pr638.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null
NBT and empty NBT are different. Does this PR allow differentiating between the two? (e.g. only accept a stack with no NBT whatsoever)
When in strict mode yes, when in partial I don't remember if vanilla differentiates between null and empty for purposes of partial nbt |
This adds support so NBT Ingredients will support the following cases (some they already supported):