[1.20.6] Add BlockTagIngredient for when a item tag cannot be used/doesn't exist #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Technici4n
reviewed
May 19, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Show resolved
Hide resolved
Technici4n
reviewed
May 19, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
- Format javadoc a bit better - Switch to jetbrains @nullable annotation - Add nullcheck to make IDE's not angry
embeddedt
reviewed
May 19, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
|
todo: implement hashCode & equals |
KnightMiner
reviewed
May 20, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
KnightMiner
reviewed
May 20, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
added
enhancement
Technici4n
reviewed
May 25, 2024
Technici4n
previously approved these changes
May 25, 2024
|
i don't really have much interest in maintaining a editorconfig pr, i'll make a separate one for the intellij icon |
Technici4n
requested changes
May 26, 2024
tests/src/main/java/net/neoforged/neoforge/debug/crafting/IngredientTests.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
…eat/blocktag-ingredient
Technici4n
previously approved these changes
May 26, 2024
pupnewfster
requested changes
May 29, 2024
src/main/java/net/neoforged/neoforge/common/crafting/BlockTagIngredient.java
Outdated
Show resolved
Hide resolved
pupnewfster
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some certain use cases using the normal tag ingredient with a ItemTag isn't always possible as a tag for that can not exist. A good example of this is
minecraft:convertable_to_mudthis tag only exists as a block tag with no ItemTag that can be used instead.Example usage: https://github.com/Creators-of-Create/Create/blob/mc1.20.1/dev/src/generated/resources/data/create/recipes/mixing/mud_by_mixing.json
The type id for this is "neoforge:block_tag"