Don't include iteration names in project directory names anymore #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchermans
approved these changes
Nov 9, 2023
…nce it may either 1) exceed the MAX_PATH limit on Windows, or 2) include characters not allowed in file-system paths (i.e. ':' on Windows). Including the name also doesn't seem to be necessary since the @tempdir that is used as the parent directory is already per-iteration.
shartte
force-pushed
the
dont-append-display-name-to-project-dir
branch
from
c66e703
to
ee1d787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not append the iteration display name to the project directory, since it may either 1) exceed the MAX_PATH limit on Windows, or 2) include characters not allowed in file-system paths (i.e. ':' on Windows).
Including the name also doesn't seem to be necessary since the
@TempDirthat is used as the parent directory is already per-iteration.