Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracy in screen.md #26

Closed
tmvkrpxl0 opened this issue Nov 14, 2023 · 2 comments · Fixed by #72
Closed

Inaccuracy in screen.md #26

tmvkrpxl0 opened this issue Nov 14, 2023 · 2 comments · Fixed by #72

Comments

@tmvkrpxl0
Copy link
Contributor

tmvkrpxl0 commented Nov 14, 2023

In sub-section Textuers, it says this:

Textures are drawn through blitting, hence the method name #blit, which, for this purpose, copies the bits of an image and draws them directly to the screen. These are drawn through a position texture shader. While there are many different #blit overloads, we will only discuss two static #blits.
The first static #blit takes in six integers and assumes the texture being rendered is on a 256 x 256 PNG file. It takes in the left x and top y screen coordinate, the left x and top y coordinate within the PNG, and the width and height of the image to render.

There isn't static method in GuiScreen. and method it refers to seems to have this signature now: public void blit(ResourceLocation pAtlasLocation, int pX, int pY, int pUOffset, int pVOffset, int pUWidth, int pVHeight)
Because it is the only method with 256 constant

@ChampionAsh5357
Copy link
Contributor

Pretty sure that was a 20.1-20.2 change iirc.

@tmvkrpxl0
Copy link
Contributor Author

tmvkrpxl0 commented Nov 17, 2023

Also
https://github.com/neoforged/Documentation/blob/main/docs/gui/screens.md?plain=1#L19C202-L19C202

These fall into five categories: colored rectangles, strings, and textures, items, and tooltips.

It has 2 ands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants