Add heading anchors #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoforged-pages-deployments
bot
deployed
to
neoforged-website-previews (Preview)
Deploying with Cloudflare Pages
|
neoforged-pages-deployments
bot
deployed
to
neoforged-website-previews (Preview)
sciwhiz12
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Overall, the change is good. Better than having to extract the ID and build the URL manually...
I think perhaps the transition being applied to the anchor button (particularly after moving the mouse away from the header) is a bit... bad. Might I suggest adding the following style:
.anchor-wrapper * {
transition: none;
}
|
Why is... whatever the heck that weird transition is even the default. Fixed. |
neoforged-pages-deployments
bot
deployed
to
neoforged-website-previews (Preview)
sciwhiz12
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy to get links to specific sections in a page by turning the headers into links -- a "link" icon shows up by them on hover, similar to GitHub markdown displays.
Preview URL: https://pr-38.neoforged-website-previews.pages.dev