Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almanac recap doesn't work with translated strings #9

Closed
maxxer opened this issue Nov 4, 2019 · 1 comment
Closed

Almanac recap doesn't work with translated strings #9

maxxer opened this issue Nov 4, 2019 · 1 comment

Comments

@maxxer
Copy link
Contributor

maxxer commented Nov 4, 2019

I don't know if it could be possible, but the almanac comparison should use strings from skin.conf:moon_phases. I don't know if this is possible

neowx/src/index.html

Lines 73 to 91 in e5f5326

#if $almanac.moon_phase == "New"
<i class="wi wi-moon-new"></i>
#else if $almanac.moon_phase == "Waxing crescent"
<i class="wi wi-moon-waxing-crescent-4"></i>
#else if $almanac.moon_phase == "First quarter"
<i class="wi wi-moon-first-quarter"></i>
#else if $almanac.moon_phase == "Waxing gibbous"
<i class="wi wi-moon-waxing-gibbous-4"></i>
#else if $almanac.moon_phase == "Full"
<i class="wi wi-moon-full"></i>
#else if $almanac.moon_phase == "Waning gibbous"
<i class="wi wi-moon-waning-gibbous-4"></i>
#else if $almanac.moon_phase == "Last quarter"
<i class="wi wi-moon-third-quarter"></i>
#else if $almanac.moon_phase == "Waning crescent"
<i class="wi wi-moon-waning-crescent-4"></i>
#else
<i class="wi wi-moon-waning-crescent-3"></i>
#end if

@neoground
Copy link
Owner

Yes, this is the best way to go. In my latest skin, NeoWX Material, I realized this in exactly this way and also included many new features and an more extensive almanac.

See: https://github.com/neoground/neowx-material/blob/master/src/header.inc#L98

You can find out more about the new skin here: https://neoground.com/projects/neowx-material

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants