fixed poor design leading to bad performance

neoice · Jun 11, 2014 · 5ab3294 · 5ab3294
1 parent cb9bbcd
commit 5ab3294
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/benchmark/apipie.rb b/benchmark/apipie.rb
@@ -11,7 +11,7 @@
 Benchmark.bm do |x|
   x.report { $client = ForemanClientPlus.new(ARGV[0])    }
   x.report { $hosts = $client.get_all_hosts               }
-  x.report { $all = []; $hosts.each {|host| $all << $client.find_host(host)} }
+  x.report { $all = []; $hosts.each {|host| $all << $client.fetch_host_details(host)} } # find_host != fetch_host_details
 end
 
 puts "Hosts collected: #{$all.length}"
diff --git a/lib/foreman_client_plus.rb b/lib/foreman_client_plus.rb
@@ -15,8 +15,11 @@ def find_host(name)
     h = raw.detect {|each| each['name'] == name}
   end
 
+  def fetch_host_details(host)
+    @api.resource(:hosts).action(:show).call(host)['results']
+  end
+
   def get_all_hosts
-    raw = @api.resource(:hosts).action(:index).call()['results']
-    raw.map {|host| host['name']}
+    @api.resource(:hosts).action(:index).call()['results']
   end
 end