Fixes for code quality

neoighodaro · Jan 6, 2019 · 6744e09 · 6744e09
1 parent b1112be
commit 6744e09
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 38 deletions.
diff --git a/src/EarlyAccess.php b/src/EarlyAccess.php
@@ -82,7 +82,7 @@ public function addAllowedNetworksToBeacon(array $networks)
      */
     public function saveBeacon(array $allowed = []): bool
     {
-        if ($data = $this->getBeaconDetails()) {
+        if ($this->getBeaconDetails()) {
             return (bool) $this->addAllowedNetworksToBeacon($allowed);
         }
 

diff --git a/src/Notifications/UserSubscribed.php b/src/Notifications/UserSubscribed.php
@@ -13,7 +13,7 @@ class UserSubscribed extends Notification implements ShouldQueue
     use Queueable;
 
     /**
-     * @var \Neo\EarlyAccess\Notifications\Subscriber
+     * @var \Neo\EarlyAccess\Subscriber
      */
     public $subscriber;
 
@@ -30,38 +30,23 @@ public function __construct(Subscriber $subscriber)
     /**
      * Get the notification's delivery channels.
      *
-     * @param  mixed $notifiable
      * @return array
      */
-    public function via($notifiable)
+    public function via()
     {
         return ['mail'];
     }
 
     /**
      * Get the mail representation of the notification.
      *
-     * @param  mixed $notifiable
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail($notifiable)
+    public function toMail()
     {
         return (new MailMessage)
             ->subject(trans('early-access::mail.subscribed.subject', ['name' => config('app.name')]))
             ->line(trans('early-access::mail.subscribed.message.intro', ['name' => config('app.name')]))
             ->action('Share on Twitter', route('early-access.share'));
     }
-
-    /**
-     * Get the array representation of the notification.
-     *
-     * @param  mixed $notifiable
-     * @return array
-     */
-    public function toArray($notifiable)
-    {
-        return [
-            //
-        ];
-    }
 }
diff --git a/src/Notifications/UserUnsubscribed.php b/src/Notifications/UserUnsubscribed.php
@@ -13,7 +13,7 @@ class UserUnsubscribed extends Notification implements ShouldQueue
     use Queueable;
 
     /**
-     * @var \Neo\EarlyAccess\Notifications\Subscriber
+     * @var \Neo\EarlyAccess\Subscriber
      */
     public $subscriber;
 
@@ -30,37 +30,22 @@ public function __construct(Subscriber $subscriber)
     /**
      * Get the notification's delivery channels.
      *
-     * @param  mixed $notifiable
      * @return array
      */
-    public function via($notifiable)
+    public function via()
     {
         return ['mail'];
     }
 
     /**
      * Get the mail representation of the notification.
      *
-     * @param  mixed $notifiable
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
-    public function toMail($notifiable)
+    public function toMail()
     {
         return (new MailMessage)
             ->subject(trans('early-access::mail.unsubscribed.subject', ['name' => config('app.name')]))
             ->line(trans('early-access::mail.unsubscribed.message.intro'));
     }
-
-    /**
-     * Get the array representation of the notification.
-     *
-     * @param  mixed $notifiable
-     * @return array
-     */
-    public function toArray($notifiable)
-    {
-        return [
-            //
-        ];
-    }
 }
diff --git a/src/Subscriber.php b/src/Subscriber.php
@@ -8,6 +8,12 @@
 use Neo\EarlyAccess\Events\UserUnsubscribed;
 use Neo\EarlyAccess\Contracts\Subscription\SubscriptionProvider;
 
+/**
+ * @property string|null email
+ * @property string|null name
+ * @property string|null subscribed_at
+ * @property boolean verified
+ */
 class Subscriber implements Arrayable
 {
     use Notifiable;

diff --git a/src/SubscriptionServices/DatabaseService.php b/src/SubscriptionServices/DatabaseService.php
@@ -9,7 +9,7 @@
 class DatabaseService implements SubscriptionProvider
 {
     /**
-     * @var \Neo\EarlyAccess\SubscriptionServices\DatabaseRepository\SubscriptionRepository
+     * @var \Neo\EarlyAccess\Contracts\Subscription\SubscriptionRepository
      */
     protected $repository;