Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust maker parameter causes wrong error report #275

Closed
zekzekus opened this issue Jan 9, 2016 · 2 comments · Fixed by #276
Closed

rust maker parameter causes wrong error report #275

zekzekus opened this issue Jan 9, 2016 · 2 comments · Fixed by #276

Comments

@zekzekus
Copy link
Contributor

zekzekus commented Jan 9, 2016

when i open my rust source files with neovim, neomake usually have an error on first line if there is an extern crate statement.

i checked sytastic plugins syntax_checker for rust programs and it uses -Z parse-only and does not raise warning for the extern crate lines.

neomake rust makes does not use this parse-only argument but using -Z no-trans. when i checked descriptions for these params:

    -Z                   parse-only -- parse only; do not compile, assemble, or link
    -Z                     no-trans -- run all passes except translation; no output

i think to use parse-only for rust make is a better idea.

@zekzekus
Copy link
Contributor Author

zekzekus commented Jan 9, 2016

please check #276

@jonhoo
Copy link

jonhoo commented Jan 20, 2016

A better long-term solution would probably be to use the rust.vim syntax checker definition like syntastic does. That way, we don't have to maintain on of our own.

xcambar added a commit to xcambar/neomake that referenced this issue Nov 1, 2016
It seems that neomake#613 deleted the args passed to rustc, as introduced in neomake#276.

This PR restores the args (`-Z parse-only`), so neomake#275 will not be reopened.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants