Wait for the next maker first error (or end) to remove signs. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! |
benekastah
added a commit
that referenced
this pull request
Mar 17, 2015
Wait for the next maker first error (or end) to remove signs.
|
Not sure why yet, but sometimes I have errors now that this PR is merged. You may want to revert the merge until I find the time to investigate. Sorry :( |
|
And of course, now that I have some time to work on this, I can not reproduce the issue (it was something about Please notify me if you encounter an issue with this PR, I will try to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some makers (e.g. rubocop running on JRuby) may take a few seconds to return the first error (in this case, because of the JVM startup time). Neomake currently removes all signs and errors as soon as
:Neomakeis called, but this is a problem with makers that take a while to start.For instance, I have bound
:NeomaketoBufwrite. Let's assume that a maker gave two errors, one on line 1 and one on line 2. If I fix the first error, then (out of habit) type:w, I have to wait a few seconds before the error on line 2 appears again.With this PR, signs and errors are not cleared when
:Neomakeis called, but when the first maker starts returning an error or is finished. This helped my workflow with JRuby, and may be useful when #46 is implemented, as building/checking large projects can take some time before the current buffer is processed.However, this could be an option rather than the default (or may be a bad idea in general :) ). What is your opinion about it?