This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Windows support #42
Merged
Windows support #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have changed the neon crate to no longer rely on this and use the node headers instead. Signed-off-by: Nathan Sobo <nathan@github.com>
Signed-off-by: Nathan Sobo <nathan@github.com>
On windows, people often use 32-bit versions of node on 64-bit systems. `npm install` works correctly in this configuration even *without* the --arch=ia32 flag, because node-gyp bases its target architecture on `process.arch`. We need to do the same thing in `neon build`.
|
@jedireza Once we merge this, I can spin a CLI 0.1.8 release, and then I should be unblocked from merging the remaining pieces of neon-bindings/neon#122. |
jedireza
reviewed
Jan 9, 2017
| @@ -25,6 +25,7 @@ const NPM_TEMPLATE = compile('package.json.hbs'); | |||
| const INDEXJS_TEMPLATE = compile('index.js.hbs'); | |||
| const LIBRS_TEMPLATE = compile('lib.rs.hbs'); | |||
| const README_TEMPLATE = compile('README.md.hbs'); | |||
| const BUILDRS_TEMPLATE = compile('build.rs.hbs'); | |||
There was a problem hiding this comment.
nit: extra space makes the = not align
This was referenced Jan 9, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #32, minus the part that actually eliminates the environment variable. Leaving that in for now for compatibility; we can eliminate it whenever we update to 0.2.