Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change top-level test workflow to use cargo #246

Closed
3 tasks done
dherman opened this issue Sep 20, 2017 · 7 comments
Closed
3 tasks done

change top-level test workflow to use cargo #246

dherman opened this issue Sep 20, 2017 · 7 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Sep 20, 2017

Running all the Neon tests should be kicked off with cargo test, which is the idiomatic way to run tests for a Rust project. This can be done by shelling out to npm etc where necessary.

  • one test called cli:
    • in the cli directory: shells out to npm install and npm run transpile
    • in the test/cli directory: shells out to npm install and npm run transpile and npm test
  • one test called static, only enabled if we're in Rust nightly:
    • in test/static directory: shells out to cargo test
    • or maybe it can be called into through a compiletest API instead of shelling from cargo to cargo?
  • one test called dynamic:
    • in test/dynamic directory: shells out to npm install and npm test

Then the CI scripts can be changed to just do a single cargo test instead of all of the above.

@humphd
Copy link

humphd commented Oct 6, 2017

I was about to file a bug on the need for improved docs for running the tests, and I noticed this. If you don't need this to be fixed immediately, I'd like to do this as an exercise with my students in class. It would let them learn about npm, TravisCI, Rust, cargo, automated tests, build automation, etc. Lots of good stuff in here.

I realize you may need this sooner than I'll have time to do with them, since we'll spend a bunch of time researching it in class, so feel free to fix it if you need to. Otherwise, I hope we'll have a PR for you in the coming weeks.

@dherman
Copy link
Collaborator Author

dherman commented Oct 11, 2017

@humphd That would be amazing! I'd be happy to help mentor any students who want to help with this, too. (I have so far been having trouble keeping to a regular schedule monitoring these issue threads, but if you ever need my attention, please feel free -- you or your students -- to ping me on slack or twitter to check a thread, I'll make sure to respond as quickly as possible.)

@dherman
Copy link
Collaborator Author

dherman commented Oct 16, 2017

@humphd Looks like @MilanLoveless got to this one already in #255, at least partially. Another infrastructure issue we could really use help with is getting #252 over the finish line -- do you think your students might be interested/able to help with that one?

@humphd
Copy link

humphd commented Oct 16, 2017

OK, thanks for letting me know. Reading that PR, it also looks like "make this work fully on Windows" might be something for them to do in future as well. RE: #252, I know that @seanprashad hit this recently, and I was suggesting he look into it. Maybe he'd like to try this?

I'll circle back to this stuff later and do some bugs with my students as it lines up with topics we're covering.

@seanprashad
Copy link

@humphd @dherman and I spoke briefly about this on Slack last night! I'd love to try and tackle #252 in the near future if that's ok with everyone 😬

@humphd
Copy link

humphd commented Oct 16, 2017

@seanprashad I think it would be a good fit for you, and give you some nice exposure to build automation, which is something I remember you expressing interest in at the start of the term.

@dherman
Copy link
Collaborator Author

dherman commented Nov 1, 2017

I believe this was fixed by @MilanLoveless in #255 (with a couple follow-up commits from me for Windows)!

@dherman dherman closed this as completed Nov 1, 2017
@divmain divmain added the archive label Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants