On Windows, build the C code in release mode always. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherman
added a commit
that referenced
this pull request
May 15, 2020
See #506 (comment) for context.
Rust always uses the release CRT, even in debug mode, so the C code should do the same.
|
I updated this PR to now still build the C code in debug mode, but I've tried my best to convince gyp to tell the C compiler to use the release CRT. The |
dherman
approved these changes
May 16, 2020
|
Thanks as always for helping us with the intricacies of building on Windows, @retep998, and again, my bad for overlooking this PR before. 🙏 |
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust always uses the release CRT, even in debug mode, so the C code should do the same.
Fixes #357