Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(neon-sys): Add a hack for recent electron versions on windows #785

Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix(neon-sys): Add a hack for recent electron versions on windows #785

merged 1 commit into from
Sep 15, 2021

Conversation

kjvalencik
Copy link
Member

Fixes #782

@kjvalencik kjvalencik mentioned this pull request Aug 31, 2021
Closed
@kjvalencik
fix(neon-sys): Add a hack for recent electron versions on windows to …
af908f9 
…use Buffer to get the contents of an ArrayBuffer

Fixes #782
@kjvalencik kjvalencik merged commit 4cd9c23 into main Sep 15, 2021
@kjvalencik kjvalencik deleted the kv/fix-win-electron branch September 15, 2021 21:58
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with Electron 13 does not work on Windows
2 participants
@kjvalencik @dherman