Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon): Add JoinHandle as a result of Channel::send #787

merged 1 commit into from
Sep 14, 2021


Copy link

Copy link

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe some comments in the test, which has kind of intricate control flow, would help. But it's up to you.

src/event/ Show resolved Hide resolved
test/napi/lib/threads.js Show resolved Hide resolved
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for neon-bindings-docs ready!

🔨 Explore the source changes: 390877f

🔍 Inspect the deploy log:

😎 Browse the preview:

@kjvalencik kjvalencik merged commit ebc5192 into next/0.10 Sep 14, 2021
@kjvalencik kjvalencik deleted the kv/join-handle branch September 14, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants