Remove feature flags from accepted RFCs #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
force-pushed
the
kv/remove-feature-flags
branch
from
9f2f779
to
4e89b0e
Compare
kjvalencik
force-pushed
the
kv/remove-feature-flags
branch
from
4e89b0e
to
e2c8e58
Compare
Merged
dherman
requested changes
Mar 16, 2022
|
@dherman After some testing, I think our best option to give a deprecation warning is to go through and on each public export that uses the feature flag, replace it with: #[cfg_attr(feature = "feature-flag", deprecated(message = "`feature-flag` is enabled by default; remove the flag"))] |
kjvalencik
force-pushed
the
kv/remove-feature-flags
branch
from
c58c63d
to
0e0c126
Compare
kjvalencik
force-pushed
the
kv/remove-feature-flags
branch
from
1f0fcb7
to
018616a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Neon uses feature flags to provide early access to features that may change while the RFC is still open. However, after accepting an RFC, the feature flag should be removed and the feature provided by default.
Overview
This PR removes several feature flags (
try-catch-api,channel-api,event-queue-api,promise-api, andtask-api). These features all have accepted RFCs.Additionally, feature flags that are only used for the
legacybackend are commented as deprecated. This will serve as a note to remove when removing thelegacybackend.Alternative
This PR completely removes the feature flags. This is a breaking change that will require users to remove the feature flag when upgrading.
Alternatively, Neon could only remove usages of the feature flag, but keep the flag in
Cargo.tomlfor backwards compatibility, deferring the breaking change to a later release.Follow-up
The
enable-static-testsfeature flag should also be removed. #871 was filed as a follow-up for this effort.