-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy #881
Remove legacy #881
Conversation
f41f9e0
to
8684081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is so gratifying 🔥
A few questions and a couple minor comments, but it looks great.
8684081
to
3d29faa
Compare
3d29faa
to
371736f
Compare
@dherman Thanks for reviewing! I added a commit to address the review feedback. Additionally, I rebased on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR includes lots of clean-ups--each as an independent commit--but, only ones that made sense to merge at once.
napi-1
. Remove these.use
statements were unnecessarily complicated. Cleaned all of theuse
statements for consistent style.neon-runtime
toneon::sys
. There isn't a reason for it to be a separate crate anymore and this will yield better performance with thin LTO.neon-build
,cli
There are a few future clean-ups I would like to perform that are not included. For example:
src
intocrates/neon
. Createnpm
directory (name?) movecreate-neon
andcargo-cp-artifact
into it.neon::sys
(formerlyneon-runtime
) methods to be more idiomatic instead of the style of legacy. This is removing a lot of out pointers. Eliminate thebuild
closurenapi
everywhere to node-api and deprecatenapi-
feature flagstransmute
unsafe
but, aren't. I've seen this most onnew_internal
andfrom_raw
methods.