Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration guide url #895

Merged
merged 2 commits into from
May 2, 2022
Merged

Fix migration guide url #895

merged 2 commits into from
May 2, 2022

Conversation

activeguild
Copy link
Contributor

Hi.
I couldn't open the migration guide, so I fixed it.

README.md Outdated
@@ -29,7 +29,7 @@ our [API docs](https://docs.rs/neon/latest/neon).

The latest version of Neon, 0.10, includes a few small breaking changes in order to clean up and improve the usability of our APIs.

**Read the new [migration guide](https://github.com/neon-bindings/neon/blob/main/docs/MIGRATION_GUIDE_0.10.md)** to learn how to port your
**Read the new [migration guide](https://github.com/neon-bindings/neon/blob/0.10.0/MIGRATION_GUIDE_0.10.md)** to learn how to port your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The correct path is doc/MIGRATION_GUIDE_0.10.md.

Looks like there's an extra s here. The version on main is preferred to the specific branch.

@activeguild
Copy link
Contributor Author

Thanks for the support.
Corrected to the correct URL.

@kjvalencik
Copy link
Member

Thanks!

@kjvalencik kjvalencik merged commit f8a508d into neon-bindings:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants