Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format checking to the CI job? #41

Closed
xffxff opened this issue May 22, 2023 · 4 comments
Closed

Add format checking to the CI job? #41

xffxff opened this issue May 22, 2023 · 4 comments

Comments

@xffxff
Copy link
Contributor

xffxff commented May 22, 2023

We currently don't verify formatting in our CI jobs, but perhaps it would be beneficial to incorporate this into our CI jobs

@neon-mmd
Copy link
Owner

We already have this GitHub action it is available as a rust_format.yml under the path .github/workflows/ and it runs 2 things, a clippy check, and a rustfmt check. but if you wish to we can separate this into two separate GitHub actions, What do you say @xffxff ?? Should we separate it??

@xffxff
Copy link
Contributor Author

xffxff commented May 23, 2023

We already have this GitHub action it is available as a rust_format.yml under the path .github/workflows/ and it runs 2 things, a clippy check, and a rustfmt check.

@neon-mmd Yes, we do have a CI job named Rust format and Clippy checks, but it only installs rustfmt and clippy without actually using them. You can refer to the log of this job to confirm this

@neon-mmd
Copy link
Owner

@neon-mmd Yes, we do have a CI job named Rust format and Clippy checks, but it only installs rustfmt and clippy without actually using them. You can refer to the log of this job to confirm this

Yes, you are right 😄 . After reading the logs I understood my mistake, my bad but thanks for pointing it out and fixing it 🙂 .

@neon-mmd
Copy link
Owner

neon-mmd commented May 23, 2023

This issue has been taken care of by PR #50, so, therefore, I mark this issue as completed 🙂 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants