Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add format and clippy checks to the CI jobs #50

Merged
merged 2 commits into from
May 23, 2023

Conversation

xffxff
Copy link
Contributor

@xffxff xffxff commented May 23, 2023

close #41

@xffxff
Copy link
Contributor Author

xffxff commented May 23, 2023

@neon-mmd You may notice that the format check currently did not pass. I intentionally kept it that way to prove that the format check was not run previously.

@xffxff
Copy link
Contributor Author

xffxff commented May 23, 2023

You may notice that the format check currently did not pass. I intentionally kept it that way to prove that the format check was not run previously.

I have now fixed the format.

@neon-mmd
Copy link
Owner

I have now fixed the format.

I was already planning to discuss fixing the formatting issues but I think you were quicker than me 😄 , now I feel I am bit lazy at maintenance work 😆 .

Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks great!! 😄 I approve it, let's merge this as well.

@neon-mmd neon-mmd merged commit 018f925 into neon-mmd:rolling May 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants