We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As an example, #807 was caused by failing to call .Inc() on the prometheus.Counter returned by WithLabelValues(...).
.Inc()
prometheus.Counter
WithLabelValues(...)
It'd be good to have automated checking of this to reduce the impact of making a similar mistake in the future.
DoD: we have a linter as part of the lints workflow that would have caught #807. Consider handling other common types as well.
I briefly searched for such a linter, but couldn't find any.
The text was updated successfully, but these errors were encountered:
There should be some I think. I know either VSCode or Goland shows you a warning if you ignore return values from a function.
Sorry, something went wrong.
No branches or pull requests
Problem description / Motivation
As an example, #807 was caused by failing to call
.Inc()
on theprometheus.Counter
returned byWithLabelValues(...)
.It'd be good to have automated checking of this to reduce the impact of making a similar mistake in the future.
Feature idea(s) / DoD
DoD: we have a linter as part of the lints workflow that would have caught #807. Consider handling other common types as well.
Implementation ideas
I briefly searched for such a linter, but couldn't find any.
The text was updated successfully, but these errors were encountered: