explicitly log layer in errors and remove span

neondatabase · Dec 15, 2023 · 239d6b7 · 239d6b7
1 parent 53b9da3
commit 239d6b7
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pageserver/src/tenant/storage_layer/layer.rs b/pageserver/src/tenant/storage_layer/layer.rs
@@ -259,7 +259,6 @@ impl Layer {
 
         layer
             .get_value_reconstruct_data(key, lsn_range, reconstruct_data, &self.0, ctx)
-            .instrument(tracing::debug_span!("get_value_reconstruct_data", layer=%self))
             .await
     }
 
@@ -1283,7 +1282,7 @@ impl DownloadedLayer {
                     // TODO(#5815): we are not logging all errors, so temporarily log them **once**
                     // here as well
                     let permanent = permanent.context("load layer");
-                    tracing::error!("layer loading failed permanently: {permanent:#}");
+                    tracing::error!("layer loading failed permanently for {owner}: {permanent:#}");
                     Ok(Err(permanent))
                 }
             }