-
Notifications
You must be signed in to change notification settings - Fork 367
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remote_storage: fix prefix handling in remote storage & clean up (#7431)
## Problem Split off from #7399, which is the first piece of code that does a WithDelimiter object listing using a prefix that isn't a full directory name. ## Summary of changes - Revise list function to not append a `/` to the prefix -- prefixes don't have to end with a slash. - Fix local_fs implementation of list to not assume that WithDelimiter case will always use a directory as a prerfix. - Remove `list_files`, `list_prefixes` wrappers, as they add little value and obscure the underlying list function -- we need callers to understand the semantics of what they're really calling (listobjectsv2)
- Loading branch information
Showing
10 changed files
with
304 additions
and
267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
e22c072
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2846 tests run: 2711 passed, 1 failed, 134 skipped (full report)
Failures on Postgres 14
test_pgbench_intensive_init_workload[neon_on-github-actions-selfhosted-1000]
: releaseCode coverage* (full report)
functions
:28.1% (6479 of 23035 functions)
lines
:47.0% (46016 of 97936 lines)
* collected from Rust tests only
e22c072 at 2024-04-23T16:16:01.931Z :recycle: