Skip to content

Commit

Permalink
Fix zenith_test_evict mode and clear_buffer_cache() function
Browse files Browse the repository at this point in the history
Using InvalidateBuffer is wrong, because if the page is concurrently
dirtied, it will throw away the dirty page without calling
smgwrite(). In Neon, that means that the last-written LSN update for
the page is missed.

In v16, use the new InvalidateVictimBuffer() function that does what
we need. In v15 and v14, backport the InvalidateVictimBuffer()
function.

Fixes issue #7802
  • Loading branch information
hlinnaka committed May 22, 2024
1 parent b43f6da commit ef96c82
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion vendor/postgres-v14
2 changes: 1 addition & 1 deletion vendor/postgres-v15
2 changes: 1 addition & 1 deletion vendor/postgres-v16
6 changes: 3 additions & 3 deletions vendor/revisions.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"v16": ["16.3", "c271017c6c4846be59948766baec2ba4ace5dc9c"],
"v15": ["15.7", "e2dbd63345c584de75173c27951f111249ae0016"],
"v14": ["14.12", "21ec61d539d22a81fe811c2d79e26436820bc3f4"]
"v16": ["16.3", "3c2b9d576c580e0b5b7108001f959b8c5b42e0a2"],
"v15": ["15.7", "74fb144890c4f955db1ef50ee1eeb9d8a6c2f69d"],
"v14": ["14.12", "0d30e28f74f49fe6a27a6bd45dcfeb1060656b8f"]
}

1 comment on commit ef96c82

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3184 tests run: 3044 passed, 0 failed, 140 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_secondary_background_downloads: debug

Code coverage* (full report)

  • functions: 31.3% (6413 of 20481 functions)
  • lines: 48.0% (49308 of 102647 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ef96c82 at 2024-05-22T12:45:01.720Z :recycle:

Please sign in to comment.