Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper type to enforce Lsn order for TimelineWriter::put_batch #6707

Closed
VladLazar opened this issue Feb 9, 2024 · 0 comments · Fixed by #7071
Closed

Add wrapper type to enforce Lsn order for TimelineWriter::put_batch #6707

VladLazar opened this issue Feb 9, 2024 · 0 comments · Fixed by #7071
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@VladLazar
Copy link
Contributor 

          How expensive do you think is it to assert this? Or, can we have a wrapper type that enforces the when we construct the batch?

This doesn't need to be addressed in this PR because it'a a pre-existing issue but let's convert this into a follow-up?

Originally posted by @problame in #6661 (comment)
@VladLazar VladLazar added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Feb 9, 2024
@VladLazar VladLazar mentioned this issue Feb 9, 2024
Merged
5 tasks
@problame problame added the m/good_first_issue Moment: when doing your first Neon contributions label Feb 9, 2024
@jbajic jbajic mentioned this issue Mar 8, 2024
Merged
5 tasks
VladLazar pushed a commit that referenced this issue Mar 21, 2024
@jbajic
Enforce LSN ordering of batch entries (#7071)
94138c1 
## Summary of changes

Enforce LSN ordering of batch entries.

Closes #6707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force LSN order with wrapper structure jbajic/neon
2 participants
@problame @VladLazar