Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layer_map_analyzer tool #3451

Merged
merged 10 commits into from
Jan 31, 2023
Merged

Add layer_map_analyzer tool #3451

merged 10 commits into from
Jan 31, 2023

Conversation

knizhnik
Copy link
Contributor

See #3348

@knizhnik knizhnik requested review from a team as code owners January 26, 2023 09:26
@knizhnik knizhnik requested review from funbringer and problame and removed request for a team January 26, 2023 09:26
@koivunej
Copy link
Contributor

@knizhnik did you forget to add the new binary, diffs are all about making items accessible?

bojanserafimov
bojanserafimov approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@bojanserafimov bojanserafimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

At some point I'll try integrating this into the visualizer too, so we can see the occupied ranges.

pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Outdated Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
pageserver/src/bin/layer_map_analyzer.rs Show resolved Hide resolved
@knizhnik knizhnik merged commit 895f929 into main Jan 31, 2023
@knizhnik knizhnik deleted the layer_map_analyzer branch January 31, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojanserafimov bojanserafimov bojanserafimov approved these changes

@funbringer funbringer Awaiting requested review from funbringer funbringer was automatically assigned from neondatabase/compute

@problame problame Awaiting requested review from problame problame is a code owner automatically assigned from neondatabase/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knizhnik @koivunej @bojanserafimov