[compute_ctl] Implement live reconfiguration #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2023
Test results for 0912d75:debug build: 212 tests run: 202 passed, 0 failed, 10 (full report)release build: 212 tests run: 202 passed, 0 failed, 10 (full report) |
piercypixel
approved these changes
Apr 7, 2023
hlinnaka
reviewed
Apr 8, 2023
ololobus
force-pushed
the
alexk/compute-reconfigure
branch
2 times, most recently
from
0b7b865
to
8158c3c
Compare
ololobus
commented
Apr 13, 2023
There was a problem hiding this comment.
Tested this together with control-plane changes https://github.com/neondatabase/cloud/pull/4512, all public API tests passed for me locally, so I'm going to merge if no objections
It will require some follow ups like retry logic for requests to control-plane, but seems to be useful for testing in the current state
With this commit one can request compute reconfiguration
from the running `compute_ctl` with compute in `Running` state
by sending a new spec:
```shell
curl -d "{\"spec\": $(cat ./compute-spec-new.json)}" http://localhost:3080/configure
```
Internally, we start a separate configurator thread that is waiting on
`Condvar` for `ConfigurationPending` compute state in a loop. Then it does
reconfiguration, sets compute back to `Running` state and notifies other
waiters.
It will need some follow-ups, e.g. for retry logic for control-plane
requests, but should be useful for testing in the current state. This
shouldn't affect any existing evironment, since computes are configured
in a different way there.
Resolves neondatabase/cloud#4433
ololobus
force-pushed
the
alexk/compute-reconfigure
branch
from
8158c3c
to
0912d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
With this commit one can request compute reconfiguration from the running
compute_ctlwith compute inRunningstate by sending a new spec:curl -d "$(cat ./compute-spec-new.json)" http://localhost:3080/specInternally, we start a separate configurator thread that is waiting on
CondvarforConfigurationPendingcompute state in a loop. Then it does reconfiguration, sets compute back toRunningstate and notifies other waiters.Issue ticket number and link
Resolves neondatabase/cloud#4433
Checklist before requesting a review
Checklist before merging