FileBlockReader<File> is never used #5181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
requested review from
save-buffer,
shanyp and
arpad-m
and removed request for
a team,
save-buffer and
shanyp
5 tasks
1624 tests run: 1549 passed, 0 failed, 75 skipped (full report)The comment gets automatically updated with the latest test results
cb977c2 at 2023-09-01T15:15:04.581Z :recycle: |
arpad-m
approved these changes
Sep 1, 2023
|
There is a failure in CI: |
jcsp
pushed a commit
that referenced
this pull request
Sep 4, 2023
5 tasks
arpad-m
added a commit
that referenced
this pull request
Sep 6, 2023
With #5181, the generics for `FileBlockReader` have been removed, so having a `Virtual` postfix makes less sense now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4743
preliminary to #5180