[WIP] Secondary locations heatmaps, downloads & tests #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
t/feature
0 tests run: 0 passed, 0 failed, 0 skipped (full report)Test coverage report is not availableThe comment gets automatically updated with the latest test results
d2e9025 at 2023-11-07T12:53:43.645Z :recycle: |
jcsp
force-pushed
the
jcsp/secondary-locations-pt3
branch
2 times, most recently
from
b60e670
to
d2e9025
Compare
Previously we were rapid-retrying, which worked when doing local loads for activating tenants, but gives us very little time for tenants that are actually taking some time to activate, e.g. in tests that use fault injection for remote storage, or lots of layers.
jcsp
force-pushed
the
jcsp/secondary-locations-pt3
branch
from
d2e9025
to
3107010
Compare
jcsp
added a commit
that referenced
this pull request
Nov 30, 2023
- During migration of tenants, it is useful for callers to `/location_conf` to flush a tenant's layers while transitioning to AttachedStale: this optimization reduces the redundant WAL replay work that the tenant's new attached pageserver will have to do. Test coverage for this will come as part of the larger tests for live migration in #5745 #5842 - Flushing is controlled with `flush_ms` query parameter: it is the caller's job to decide how long they want to wait for a flush to complete. If flush is not complete within the time limit, the pageserver proceeds to succeed anyway: flushing is only an optimization. - Add swagger definitions for all this: the location_config API is the primary interface for driving tenant migration as described in docs/rfcs/028-pageserver-migration.md, and will eventually replace the various /attach /detach /load /ignore APIs. --------- Co-authored-by: Joonas Koivunen <joonas@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5367
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging