remove pageserver remotes support #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and feature itself is delayed (#136)
LizardWizzard
force-pushed
the
feature/remove-remote-pageserver-cli
branch
from
599a89e
to
78153df
Compare
lubennikovaav
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
LGTM,
There is one more comment referring remote pageserver, that needs an update
https://github.com/zenithdb/zenith/blob/main/zenith_utils/src/zid.rs#L128
|
@lubennikovaav I decided to keep it because it explains why we need random id's and it doesnt explain any particular implementation details, but just underlines scenarios when this can be useful. So IMO it's ok to keep it as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we do not have tests for that and feature itself is delayed (#136)
needed to simplify #565