walredo: stderr cleanup & make explicitly cancel safe #6031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I need walredo to be cancellation-safe for #6000 (comment)
Solution
We are only
async fn
because ofwait_for(stderr_logger_task_done).await
, added in #5560 .The
stderr_logger_cancel
andstderr_logger_task_done
were there out of precaution that the stderr logger task might for some reason not stop when the walredo process terminates.That hasn't been a problem in practice.
So, simplify things:
stderr_logger_cancel
and thewait_for(...stderr_logger_task_done...)
tokio::process::ChildStderr
in the stderr logger task