Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(walredo): various observability improvements #6573

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat(walredo): various observability improvements #6573

merged 4 commits into from
Feb 1, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Feb 1, 2024 •
edited
Loading

  • log when we start walredo process
  • include tenant shard id in walredo argv
  • dump some basic walredo state in tenant details api
  • more suitable walredo process launch histogram buckets
  • avoid duplicate tracing labels in walredo launch spans

@problame problame mentioned this pull request Feb 1, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

2376 tests run: 2264 passed, 0 failed, 112 skipped (full report)

Flaky tests (7)

Postgres 16

  • test_gc_cutoff: debug
  • test_deletion_queue_recovery[no-validate-lose]: debug

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: release
  • test_lfc_resize: debug
  • test_emergency_mode: release

Postgres 14

  • test_gc_cutoff: debug
  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage (full report)

  • functions: 54.4% (11230 of 20632 functions)
  • lines: 81.5% (63284 of 77680 lines)
The comment gets automatically updated with the latest test results
d3bef3e at 2024-02-01T20:25:50.701Z :recycle:

@problame
feat(walredo): various observability improvements
a319d1e 
- log when we start walredo process
- include tenant shard id in walredo argv
- dump some basic walredo state in tenant details api
- more suitable walredo process launch histogram buckets
- avoid duplicate tracing labels in walredo launch spans
@problame
unstack from #6572
dc03067
@problame problame force-pushed the problame/2024-02-walredo-work/3-observability-improvements branch from 721e400 to dc03067 Compare February 1, 2024 17:44
@problame problame changed the base branch from problame/2024-02-walredo-work/3.1-debug_assert-shard-id to main February 1, 2024 17:46
@problame problame marked this pull request as ready for review February 1, 2024 17:51
@problame problame requested review from a team as code owners February 1, 2024 17:51
@problame problame requested review from conradludgate and jcsp and removed request for a team and conradludgate February 1, 2024 17:51
@problame problame merged commit 7a70ef9 into main Feb 1, 2024
47 checks passed
@problame problame deleted the problame/2024-02-walredo-work/3-observability-improvements branch February 1, 2024 20:59
@problame problame mentioned this pull request Feb 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

@koivunej koivunej koivunej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@problame @jcsp @koivunej