tests: log hygiene checks for storage controller

[jcsp]

Problem

As with the pageserver, we should fail tests that emit unexpected log errors/warnings.

Summary of changes

• Refactor existing log checks to be reusable
• Run log checks for attachment_service
• Add allow lists as needed.

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.
• Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
• If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

• Do not forget to reformat commit message to not include the above checklist

[github-actions]

2706 tests run: 2575 passed, 0 failed, 131 skipped (full report)

---

Flaky tests (1)

Postgres 16

• test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: debug

Code coverage* (full report)

• functions: 28.3% (7131 of 25173 functions)
• lines: 46.9% (43725 of 93325 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
654fc72 at 2024-03-19T10:41:50.168Z :recycle:}