Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in provider.rs error message #6864

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

tristan957
Copy link
Member

s/temporary/temporarily

@tristan957 tristan957 requested a review from a team as a code owner February 21, 2024 16:21
@tristan957 tristan957 requested review from khanova and removed request for a team February 21, 2024 16:21
@tristan957
Copy link
Member Author

Do I also need to touch up the dashboard search results here: https://github.com/search?q=org%3Aneondatabase+%22temporary+unavailable%22&type=code

@tristan957
Copy link
Member Author

@danieltprice @bgrenon this is a user facing error message. Do you think the period should be substituted for a colon or something else? Lower case starts to sentences are annoying to me 😄.

@bgrenon
Copy link
Contributor

bgrenon commented Feb 21, 2024

@danieltprice @bgrenon this is a user facing error message. Do you think the period should be substituted for a colon or something else? Lower case starts to sentences are annoying to me 😄.

Unless this is going against a wider convention, period is ok. But then the next sentence also needs to be fixed with a starting Cap and period.

Co-authored-by: Barry Grenon <barry_grenon@yahoo.ca>
Copy link

2466 tests run: 2344 passed, 0 failed, 122 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_remote_timeline_client_calls_started_metric: debug

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 28.8% (6756 of 23462 functions)
  • lines: 47.6% (41076 of 86306 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b84a1f2 at 2024-02-21T19:16:02.781Z :recycle:

@tristan957 tristan957 merged commit 69337be into main May 6, 2024
48 of 49 checks passed
@tristan957 tristan957 deleted the tristan957/grammar branch May 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants