New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add authentication rate limiting #6865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2718 tests run: 2580 passed, 0 failed, 138 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7e584d6 at 2024-03-25T18:25:11.222Z :recycle: |
conradludgate
force-pushed
the
auth-limiter
branch
4 times, most recently
from
March 25, 2024 11:12
644413c
to
5ca41ca
Compare
conradludgate
force-pushed
the
auth-limiter
branch
from
March 25, 2024 11:26
5ca41ca
to
4b534e9
Compare
khanova
approved these changes
Mar 25, 2024
khanova
approved these changes
Mar 25, 2024
khanova
reviewed
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/neondatabase/cloud/issues/9642
Summary of changes
EndpointRateLimiter
generic, renamed asBucketRateLimiter
AuthRateLimiter
alias.(Endpoint, IP)
pair during authentication, weighted by how many hashes proxy would be doing.TODO: handle ipv6 subnets. will do this in a separate PR.
Checklist before requesting a review
Checklist before merging