Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove legacy attach/detach APIs from swagger #6883

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Feb 22, 2024

Problem

Since the location config API was added, the attach and detach endpoints are deprecated. Hiding them from consumers of the swagger definition is a precursor to removing them

Neon's cloud no longer uses this api since https://github.com/neondatabase/cloud/pull/10538

Fully removing the APIs will implicitly make use of generation numbers mandatory, and should happen alongside #5388, which will happen once we're happy that the storage controller is ready for prime time.

Summary of changes

  • Remove /attach and /detach from pageserver's swagger file

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Feb 22, 2024
@jcsp jcsp requested a review from a team as a code owner February 22, 2024 15:00
@jcsp jcsp requested review from problame and removed request for a team February 22, 2024 15:00
@problame
Copy link
Contributor

The (undocumented) procedure for removals is to do that in the cloud.git first. Did that happen already?

Copy link

github-actions bot commented Feb 22, 2024

2418 tests run: 2298 passed, 0 failed, 120 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_remote_timeline_client_calls_started_metric: debug
  • test_vm_bit_clear_on_heap_lock: release

Postgres 15

  • test_pg_regress[None]: debug
  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Postgres 14

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage* (full report)

  • functions: 28.8% (6778 of 23531 functions)
  • lines: 47.6% (41240 of 86559 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c0ffd8e at 2024-02-23T16:38:48.634Z :recycle:

@jcsp
Copy link
Contributor Author

jcsp commented Feb 22, 2024

The (undocumented) procedure for removals is to do that in the cloud.git first. Did that happen already?

In this case I've just announced the change to that team (I had earlier checked that on the linked PR they weren't using the API any more).

@jcsp jcsp force-pushed the jcsp/swagger-cleanup-attach branch from b0431bd to c0ffd8e Compare February 23, 2024 15:54
@jcsp jcsp enabled auto-merge (squash) February 23, 2024 17:47
@jcsp jcsp merged commit 8283779 into main Feb 25, 2024
50 checks passed
@jcsp jcsp deleted the jcsp/swagger-cleanup-attach branch February 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants